fix(edge-converter): Ensure null body status codes dont return a body #906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e14a354 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
conico974
reviewed
Jun 17, 2025
Co-authored-by: conico974 <[email protected]>
This was referenced Jun 18, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For opennextjs/opennextjs-cloudflare#684
We need to ensure that the response doesn't return a body if its a status code that does not allow it. (101, 204, 205, 304).
Here is a reproduction I made for that issue. To run the reproduction just
pnpm install && pnpm preview. Then in another terminal youcurl -i http://localhost:8787/src2.We could fix this inside the
overrides/proxyExternalRequest/fetch.tsaswell. We would just return the body as is, and not fallback toemptyReadableStream(). Not sure what would be preferred? I dont thinkemptyReadableStream()has any effect in this converter.